Merged
Conversation
Contributor
Author
|
erroneously created previous PR on master - thus current changes are expecting that PR to be merged - after this additional lines will go away. |
There was a problem hiding this comment.
Pull request overview
This pull request modernizes type casting in the codebase by replacing C-style casts with C++ static_cast, which provides better type safety and makes type conversions more explicit. The changes address "issue 1000" which likely pertains to adopting modern C++ casting conventions.
Key Changes:
- Converted C-style casts
(type)valuetostatic_cast<type>(value)throughout xmltest.cpp for integer and double conversions - Removed an unnecessary
static_cast<int>in tinyxml2.cpp wheresize_ttosize_tconversion was already correct
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| xmltest.cpp | Converted all C-style casts to static_cast for timing calculations, attribute type conversions, and test assertions |
| tinyxml2.cpp | Removed unnecessary cast from size_t to int in XMLPrinter::Write, as PushArr expects size_t directly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.