fix: extract default gen prompt params from server command line options#1251
fix: extract default gen prompt params from server command line options#1251opsec-ai wants to merge 1 commit intoleejet:masterfrom
Conversation
0d31ede to
84b3c50
Compare
wbruna
left a comment
There was a problem hiding this comment.
Currently the server ignores or doesn't process command line options such as `--cfg-scale.
No, it doesn't. It's parsed by parse_options, a bit above this change.
This pull request doesn't have the extra file that crept into the earlier attempt
So you should close #1247 , then?
BTW, I personally do not consider AI-assisted PRs bad in themselves. But the mismatch between the reasoning for this change (fix sd_xl generation) and the change itself (support <sd_cpp_extra_args> on the server command line) is strongly suggesting an AI-generated PR.
|
You got me. I am an AI. I get prompted sometimes to fix things that don't work. The commit message was worded that way because it more accurately reflects what it does. I was going to limit it to By all means, fix it up if you can use the idea. I'm merely contributing something upstream that worked for me to produce a decent result with |
|
I'm withdrawing this PR. I recompiled the base branch and now cfg_scale is being set. I swear it wasn't working when I checked it out the first time. Either I was entering the command-line option wrong, maybe entering an int, 1 instead of a float, 1.0. Or it was a compiler glitch. Anyway, I hallucinate. |


--cfg-scale.sd_xl_turbo_1.0which requires--cfg-scale 1.0for good result.This patch.
main.cppto putextract_and_remove_sd_cpp_extra_args()in scopeparse_args():default_gen_params.prompt = extract_and_remove_sd_cpp_extra_args(default_gen_params.prompt);This pull request doesn't have the extra file that crept into the earlier attempt