[Remove Vuetify from Studio] Convert Sign In page unit tests to Vue Testing Library#5576
Conversation
|
Hii @MisRob, can you please have a look and provide a reviewer for this PR, implementation is complete and If any changes require please let me know. |
|
Thank you @vtushar06, we will assign a reviewer soon. I gave it a very quick skim, and I appreciate that you applied all the recent learnings. A reviewer will check on it in more detail, but high-level it looks nice! |
LianaHarris360
left a comment
There was a problem hiding this comment.
The tests pass, covering test cases from the user perspective and follow the recommended style guidelines, thanks so much @vtushar06 !
|
Hii @LianaHarris360, Thanks for approving and merging this, can you please look into similar PR #5536. |
|
No problem! And a reviewer has already been assigned to that pull request, they will review it when they have the opportunity :) |
Summary
Converted AccountsMain (Sign In page) unit tests from Vue Test Utils to Vue Testing Library, focusing on user-observable behavior instead of implementation details.
Changes:
mount()withrender()and Vue Testing Library queriesmocks: { $store }instead ofcreateLocalVue(component only uses dispatch/state)PolicyModalsstub keptTest Coverage:
?next=parameterAll tests use semantic queries (
getByRole,getByLabelText,getByText) and test only user-visible behavior.…
References
Reviewer guidance
Testing:
…