chore: isolate String.length#12566
Draft
TwoFX wants to merge 2 commits intoleanprover:masterfrom
Draft
Conversation
Member
Author
|
!radar |
|
Benchmark results for 91a0f41 against 043b8a7 are in! @TwoFX
Large changes (1🟥)
Medium changes (3🟥)
Small changes (3✅, 103🟥) Too many entries to display here. View the full report on radar instead. |
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Member
Author
|
!radar |
|
Benchmark results for 12bfa48 against 043b8a7 are in! @TwoFX
Large changes (1🟥)
Medium changes (3🟥)
Small changes (3✅, 101🟥) Too many entries to display here. View the full report on radar instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all uses of the
String.lengthfunction from core.This is in preparation for a future deprecation of the
String.lengthfunction. Note: the string length can still be obtained in linear time usings.chars.length.