Skip to content

[Merged by Bors] - chore(RingTheory/Ideal/KrullsHeightTheorem): fix capitalization of minimalPrimes#37463

Closed
hommmmm wants to merge 10 commits intoleanprover-community:masterfrom
hommmmm:krull-height-theorem-style
Closed

[Merged by Bors] - chore(RingTheory/Ideal/KrullsHeightTheorem): fix capitalization of minimalPrimes#37463
hommmmm wants to merge 10 commits intoleanprover-community:masterfrom
hommmmm:krull-height-theorem-style

Conversation

@hommmmm
Copy link
Copy Markdown
Contributor

@hommmmm hommmmm commented Mar 31, 2026

Fixed capitalization convention for minimal_prime to lower camel case minimalPrime according to mathlib naming conventions. There is one changed lemma in RingTheory/Ideal/KrullsHeightTheorem and one in RingTheory/Ideal/MinimalPrime/Localization.


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Mar 31, 2026
@github-actions
Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

PR summary 0f45f4bd60

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Ideal.height_le_spanRank_toENat_of_mem_minimalPrimes
+ Ideal.minimalPrimes_comap_of_surjective

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@themathqueen
Copy link
Copy Markdown
Collaborator

Thanks! Can you please add deprecations of the changed results (see https://leanprover-community.github.io/contribute/style.html#deprecation))?

Copy link
Copy Markdown
Collaborator

@Multramate Multramate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once deprecations are added, thanks!

hommmmm added 2 commits April 1, 2026 14:51
For 2 changed results Ideal.height_le_spanRank_toENat_of_mem_minimalPrimes and Ideal.minimalPrimes_comap_subset
Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awaiting-author

Comment thread Mathlib/RingTheory/Ideal/MinimalPrime/Localization.lean
Comment thread Mathlib/RingTheory/Ideal/KrullsHeightTheorem.lean
Comment thread Mathlib/RingTheory/Ideal/MinimalPrime/Localization.lean Outdated
@themathqueen themathqueen added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 4, 2026
@hommmmm
Copy link
Copy Markdown
Contributor Author

hommmmm commented Apr 4, 2026

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 4, 2026
Comment thread Mathlib/RingTheory/Ideal/MinimalPrime/Localization.lean
hommmmm and others added 3 commits April 6, 2026 19:28
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Copy link
Copy Markdown
Member

@chrisflav chrisflav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The PR description says that there are 8 + 2 occurrences, but I only see two changed lemmas. Could you please fix that?

Otherwise, LGTM

@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 14, 2026
@hommmmm
Copy link
Copy Markdown
Contributor Author

hommmmm commented Apr 14, 2026

Thanks! The PR description says that there are 8 + 2 occurrences, but I only see two changed lemmas. Could you please fix that?

Otherwise, LGTM

Thanks! I clarified.

@hommmmm
Copy link
Copy Markdown
Contributor Author

hommmmm commented Apr 14, 2026

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 14, 2026
@chrisflav chrisflav changed the title style(RingTheory/Ideal/KrullsHeightTheorem): capitalization convention for minimalPrimes chore(RingTheory/Ideal/KrullsHeightTheorem): fix capitalization of minimalPrimes Apr 14, 2026
@chrisflav
Copy link
Copy Markdown
Member

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by chrisflav.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 14, 2026
Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 15, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 15, 2026
…inimalPrimes` (#37463)

Fixed capitalization convention for `minimal_prime` to lower camel case `minimalPrime` according to mathlib naming conventions. There is one changed lemma in `RingTheory/Ideal/KrullsHeightTheorem` and one in `RingTheory/Ideal/MinimalPrime/Localization`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 15, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(RingTheory/Ideal/KrullsHeightTheorem): fix capitalization of minimalPrimes [Merged by Bors] - chore(RingTheory/Ideal/KrullsHeightTheorem): fix capitalization of minimalPrimes Apr 15, 2026
@mathlib-bors mathlib-bors bot closed this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants