[Merged by Bors] - chore(RingTheory/Ideal/KrullsHeightTheorem): fix capitalization of minimalPrimes#37463
[Merged by Bors] - chore(RingTheory/Ideal/KrullsHeightTheorem): fix capitalization of minimalPrimes#37463hommmmm wants to merge 10 commits intoleanprover-community:masterfrom
minimalPrimes#37463Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary 0f45f4bd60Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
|
Thanks! Can you please add deprecations of the changed results (see https://leanprover-community.github.io/contribute/style.html#deprecation))? |
Multramate
left a comment
There was a problem hiding this comment.
Approved once deprecations are added, thanks!
For 2 changed results Ideal.height_le_spanRank_toENat_of_mem_minimalPrimes and Ideal.minimalPrimes_comap_subset
|
-awaiting-author |
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
chrisflav
left a comment
There was a problem hiding this comment.
Thanks! The PR description says that there are 8 + 2 occurrences, but I only see two changed lemmas. Could you please fix that?
Otherwise, LGTM
Thanks! I clarified. |
|
-awaiting-author |
minimalPrimes
|
Thanks! |
|
🚀 Pull request has been placed on the maintainer queue by chrisflav. |
…inimalPrimes` (#37463) Fixed capitalization convention for `minimal_prime` to lower camel case `minimalPrime` according to mathlib naming conventions. There is one changed lemma in `RingTheory/Ideal/KrullsHeightTheorem` and one in `RingTheory/Ideal/MinimalPrime/Localization`.
|
Pull request successfully merged into master. Build succeeded: |
minimalPrimesminimalPrimes
Fixed capitalization convention for
minimal_primeto lower camel caseminimalPrimeaccording to mathlib naming conventions. There is one changed lemma inRingTheory/Ideal/KrullsHeightTheoremand one inRingTheory/Ideal/MinimalPrime/Localization.