Skip to content

feat(FunctionField): a function field is finite over Fq(y) for transcendental y#37447

Open
xgenereux wants to merge 6 commits intoleanprover-community:masterfrom
xgenereux:FiniteOverAdjoinTranscendental
Open

feat(FunctionField): a function field is finite over Fq(y) for transcendental y#37447
xgenereux wants to merge 6 commits intoleanprover-community:masterfrom
xgenereux:FiniteOverAdjoinTranscendental

Conversation

@xgenereux
Copy link
Copy Markdown
Collaborator

@xgenereux xgenereux commented Mar 31, 2026

Given F a function field over Fq, we know by assumption that it is finite over RatFunc Fq.
This PR adds the result that it is also finite over Fq(y) for any transcendental y over Fq.

Notes:

  1. Instance synthesis is known to be slow with IntermediateField, so we guide it in the proof of finiteDimensional_of_adjoin_transcendental.
  2. While looking for the proof of Module.Finite.top_left, it took me a while to find Module.Finite.of_surjective as I was looking for equiv lemmas. I've added a comment in the docstring of Module.Finite.of_equiv_equiv to ease discovery.
  3. Since LinearMap.id' requires σ to have the same domain and codomain, we explicitly provide a generalized version of it in the proof of Module.Finite.top_left.

Co-authored-by: María Inés de Frutos Fernández <mariaines.dff@gmail.com>


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

PR summary 044631201f

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.NumberTheory.FunctionField 2244 2253 +9 (+0.40%)
Import changes for all files
Files Import difference
3 files Mathlib.NumberTheory.ClassNumber.FunctionField Mathlib.NumberTheory.FunctionField Mathlib.NumberTheory.RatFunc.Ostrowski
9

Declarations diff

+ Algebra.IsAlgebraic.adjoin_algebraMap_X
+ FiniteDimensional.adjoin_X
+ FiniteDimensional.adjoin_algebraMap_X
+ finiteDimensional_of_adjoin_transcendental
+ isAlgebraic_X_over_adjoin_transcendental
+ top_left

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@xgenereux xgenereux changed the title feat(FunctionField): a function field is finite over Fq(y) for transc. y feat(FunctionField): a function field is finite over Fq(y) for transcendental y Mar 31, 2026
@xgenereux xgenereux added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-number-theory Number theory (also use t-algebra or t-analysis to specialize) labels Apr 1, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 5, 2026
@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor

I would greatly appreciate a (separate) PR that changes Fq (which misleadingly suggests that Fq is a finite field) to a more generic field variable like K throughout this file.

@MichaelStollBayreuth MichaelStollBayreuth added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 10, 2026
@xgenereux
Copy link
Copy Markdown
Collaborator Author

I've added a dependency to your requested PR.

@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 10, 2026
@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor

MichaelStollBayreuth commented Apr 10, 2026

You'll have to merge master to fix the build (see the announcement on Zulip).

@xgenereux
Copy link
Copy Markdown
Collaborator Author

xgenereux commented Apr 10, 2026

Thanks for the heads up. (I'll wait on #37894.)

mathlib-bors bot pushed a commit that referenced this pull request Apr 11, 2026
…ite (#37894)

Asked by @MichaelStollBayreuth [here](#37447 (comment)).

I've also slightly adjusted the doc to reflect this.

I used the notation which I know from Rosen - Number Theory in Function Field.

Co-authored-by: Xavier Genereux <xaviergenereux@hotmail.com>
@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 11, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

@xgenereux xgenereux removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants