feat(FunctionField): a function field is finite over Fq(y) for transcendental y#37447
Open
xgenereux wants to merge 6 commits intoleanprover-community:masterfrom
Open
feat(FunctionField): a function field is finite over Fq(y) for transcendental y#37447xgenereux wants to merge 6 commits intoleanprover-community:masterfrom
Fq(y) for transcendental y#37447xgenereux wants to merge 6 commits intoleanprover-community:masterfrom
Conversation
PR summary 044631201f
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.NumberTheory.FunctionField | 2244 | 2253 | +9 (+0.40%) |
Import changes for all files
| Files | Import difference |
|---|---|
3 filesMathlib.NumberTheory.ClassNumber.FunctionField Mathlib.NumberTheory.FunctionField Mathlib.NumberTheory.RatFunc.Ostrowski |
9 |
Declarations diff
+ Algebra.IsAlgebraic.adjoin_algebraMap_X
+ FiniteDimensional.adjoin_X
+ FiniteDimensional.adjoin_algebraMap_X
+ finiteDimensional_of_adjoin_transcendental
+ isAlgebraic_X_over_adjoin_transcendental
+ top_left
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Fq(y) for transcendental y
41f6dd4 to
0a7a989
Compare
Contributor
|
I would greatly appreciate a (separate) PR that changes |
Collaborator
Author
|
I've added a dependency to your requested PR. |
Contributor
|
You'll have to merge master to fix the build (see the announcement on Zulip). |
Collaborator
Author
|
Thanks for the heads up. (I'll wait on #37894.) |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 11, 2026
…ite (#37894) Asked by @MichaelStollBayreuth [here](#37447 (comment)). I've also slightly adjusted the doc to reflect this. I used the notation which I know from Rosen - Number Theory in Function Field. Co-authored-by: Xavier Genereux <xaviergenereux@hotmail.com>
|
This PR/issue depends on: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given
Fa function field overFq, we know by assumption that it is finite overRatFunc Fq.This PR adds the result that it is also finite over
Fq(y)for any transcendentalyoverFq.Notes:
IntermediateField, so we guide it in the proof offiniteDimensional_of_adjoin_transcendental.Module.Finite.top_left, it took me a while to findModule.Finite.of_surjectiveas I was looking for equiv lemmas. I've added a comment in the docstring ofModule.Finite.of_equiv_equivto ease discovery.LinearMap.id'requiresσto have the same domain and codomain, we explicitly provide a generalized version of it in the proof ofModule.Finite.top_left.Co-authored-by: María Inés de Frutos Fernández <mariaines.dff@gmail.com>