refactor(Algebra): uniform API for substructures#37446
refactor(Algebra): uniform API for substructures#37446artie2000 wants to merge 12 commits intoleanprover-community:masterfrom
Conversation
PR summary 6db85f34e4Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| i.mul_mem (by apply Set.mem_iInter₂.1 hx i h) (by apply Set.mem_iInter₂.1 hy i h) }⟩ | ||
|
|
||
| @[to_additive (attr := simp, norm_cast)] | ||
| theorem coe_sInf (S : Set (Subsemigroup M)) : ((sInf S : Subsemigroup M) : Set M) = ⋂ s ∈ S, ↑s := |
There was a problem hiding this comment.
a) Can you deprecate instead of remove?
b) Should the PR both define IsConcreteSInf and start using it? Or can those be separate concerns?
There was a problem hiding this comment.
the "using it" part is just for testing - I'll mark the PR WIP sorry
defining and using should be separate PRs
There was a problem hiding this comment.
we may not even decide to remove all these declarations (I personally am in favour of removing)
then this PR just means we can stop having to maintain them
There was a problem hiding this comment.
We should certainly have one PR for just implementing it, and another draft PR which battle tests it.
Co-authored-by: Violeta Hernández Palacios <vi.hdz.p@gmail.com>
SetLikeinstances whose map preserves meets - the intended interpretation is substructures whose closure properties are preserved under intersectionCompleteLatticeinstance andclosureadjunction on such instancesThis change unifies a significant part of the API for algebraic substructures.
SetLike#32984Original PR: #25963