Skip to content

feat(Mathlib/Analysis/Polynomial/MahlerMeasure): Mahler Measure estimate in terms of supNorm#35280

Open
khwilson wants to merge 9 commits intoleanprover-community:masterfrom
khwilson:mahler-estimate
Open

feat(Mathlib/Analysis/Polynomial/MahlerMeasure): Mahler Measure estimate in terms of supNorm#35280
khwilson wants to merge 9 commits intoleanprover-community:masterfrom
khwilson:mahler-estimate

Conversation

@khwilson
Copy link
Contributor

The Mahler measure of a polynomial is bounded above by √(p.natDegree + 1) * p.supNorm. This is a tighter estimate than (p.natDegree + 1) * p.supNorm, which is implied by mahlerMeasure_le_sum_norm_coeff.

AI Usage: Claude Code (Opus 4.6) provided first drafts for several sorries in the main calc block. Gemini Pro was used for one-off looks ups of lemma names like ae_restrict_iff'. The final code was edited by me.

Open in Gitpod

…ate in terms of supNorm

The Mahler measure of a polynomial is bounded above by
`√(p.natDegree + 1) * p.supNorm`. This is a tighter estimate than
`(p.natDegree + 1) * p.supNorm`, which is implied by
`mahlerMeasure_le_sum_norm_coeff`.
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Feb 13, 2026
@github-actions
Copy link

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

PR summary f618ef9056

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Analysis.Polynomial.MahlerMeasure 2683 2731 +48 (+1.79%)
Import changes for all files
Files Import difference
Mathlib.NumberTheory.MahlerMeasure 44
Mathlib.Analysis.Polynomial.MahlerMeasure 48

Declarations diff

+ mahlerMeasure_le_sqrt_natDegree_add_one_mul_supNorm

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
11958 1 backward.isDefEq

Current commit 095fe9333b
Reference commit f618ef9056

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Feb 13, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 18, 2026
@mathlib-merge-conflicts
Copy link

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 18, 2026
Copy link
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this looks pretty nice!

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 24, 2026
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@github-actions github-actions bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 24, 2026
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 24, 2026
khwilson and others added 2 commits February 24, 2026 18:39
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@khwilson
Copy link
Contributor Author

Thanks! Responded to comments and pushed.

@khwilson
Copy link
Contributor Author

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants