feat(Mathlib/Analysis/Polynomial/MahlerMeasure): Mahler Measure estimate in terms of supNorm#35280
feat(Mathlib/Analysis/Polynomial/MahlerMeasure): Mahler Measure estimate in terms of supNorm#35280khwilson wants to merge 9 commits intoleanprover-community:masterfrom
Conversation
…ate in terms of supNorm The Mahler measure of a polynomial is bounded above by `√(p.natDegree + 1) * p.supNorm`. This is a tighter estimate than `(p.natDegree + 1) * p.supNorm`, which is implied by `mahlerMeasure_le_sum_norm_coeff`.
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary f618ef9056
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Analysis.Polynomial.MahlerMeasure | 2683 | 2731 | +48 (+1.79%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.NumberTheory.MahlerMeasure |
44 |
Mathlib.Analysis.Polynomial.MahlerMeasure |
48 |
Declarations diff
+ mahlerMeasure_le_sqrt_natDegree_add_one_mul_supNorm
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for scripts/declarations_diff.sh contains some details about this script.
Increase in tech debt: (relative, absolute) = (1.00, 0.00)
| Current number | Change | Type |
|---|---|---|
| 11958 | 1 | backward.isDefEq |
Current commit 095fe9333b
Reference commit f618ef9056
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
This pull request has conflicts, please merge |
j-loreaux
left a comment
There was a problem hiding this comment.
overall this looks pretty nice!
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
|
Thanks! Responded to comments and pushed. |
|
-awaiting-author |
The Mahler measure of a polynomial is bounded above by
√(p.natDegree + 1) * p.supNorm. This is a tighter estimate than(p.natDegree + 1) * p.supNorm, which is implied bymahlerMeasure_le_sum_norm_coeff.AI Usage: Claude Code (Opus 4.6) provided first drafts for several sorries in the main calc block. Gemini Pro was used for one-off looks ups of lemma names like
ae_restrict_iff'. The final code was edited by me.