Skip to content

[Merged by Bors] - refactor(Topology/Algebra/Module/LinearMap): adjust statement of coe_mul and coe_pow#35269

Closed
tb65536 wants to merge 5 commits intoleanprover-community:masterfrom
tb65536:tb_coe_pow
Closed

[Merged by Bors] - refactor(Topology/Algebra/Module/LinearMap): adjust statement of coe_mul and coe_pow#35269
tb65536 wants to merge 5 commits intoleanprover-community:masterfrom
tb65536:tb_coe_pow

Conversation

@tb65536
Copy link
Copy Markdown
Contributor

@tb65536 tb65536 commented Feb 13, 2026

In Topology/Algebra/Module/LinearMap, it seems to be the pattern to have coe_zero/coe_id/coe_add/coe_neg/coe_sub for the coercions from ContinuousLinearMap to LinearMap and primed versions coe_zero'/coe_id'/coe_add'/coe_neg'/coe_sub' for the coercions from ContinuousLinearMap to Function.

This PR adjusts the statements of coe_mul and coe_pow to fit this pattern, as well as adding coe_one.


Open in Gitpod

@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-topology Topological spaces, uniform spaces, metric spaces, filters t-algebra Algebra (groups, rings, fields, etc) labels Feb 13, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 13, 2026

PR summary 89bf6044f9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ coe_mul'
+ coe_one
+ coe_pow'

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Feb 13, 2026
@dagurtomas dagurtomas removed their assignment Feb 26, 2026
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Mar 3, 2026

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Mar 3, 2026
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Mar 3, 2026

I note that this is three weeks old so just in case it needs merge of master:

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Mar 3, 2026

✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage Bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Mar 3, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Mar 3, 2026

Canceled.

@tb65536
Copy link
Copy Markdown
Contributor Author

tb65536 commented Mar 3, 2026

bors r+

mathlib-bors Bot pushed a commit that referenced this pull request Mar 3, 2026
…_mul` and `coe_pow` (#35269)

In `Topology/Algebra/Module/LinearMap`, it seems to be the pattern to have `coe_zero`/`coe_id`/`coe_add`/`coe_neg`/`coe_sub` for the coercions from `ContinuousLinearMap` to `LinearMap` and primed versions `coe_zero'`/`coe_id'`/`coe_add'`/`coe_neg'`/`coe_sub'` for the coercions from `ContinuousLinearMap` to `Function`.

This PR adjusts the statements of `coe_mul` and `coe_pow` to fit this pattern, as well as adding `coe_one`.

Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Mar 3, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title refactor(Topology/Algebra/Module/LinearMap): adjust statement of coe_mul and coe_pow [Merged by Bors] - refactor(Topology/Algebra/Module/LinearMap): adjust statement of coe_mul and coe_pow Mar 3, 2026
@mathlib-bors mathlib-bors Bot closed this Mar 3, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Mar 10, 2026
…_mul` and `coe_pow` (leanprover-community#35269)

In `Topology/Algebra/Module/LinearMap`, it seems to be the pattern to have `coe_zero`/`coe_id`/`coe_add`/`coe_neg`/`coe_sub` for the coercions from `ContinuousLinearMap` to `LinearMap` and primed versions `coe_zero'`/`coe_id'`/`coe_add'`/`coe_neg'`/`coe_sub'` for the coercions from `ContinuousLinearMap` to `Function`.

This PR adjusts the statements of `coe_mul` and `coe_pow` to fit this pattern, as well as adding `coe_one`.

Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
pevogam pushed a commit to pevogam/mathlib4 that referenced this pull request Mar 19, 2026
…_mul` and `coe_pow` (leanprover-community#35269)

In `Topology/Algebra/Module/LinearMap`, it seems to be the pattern to have `coe_zero`/`coe_id`/`coe_add`/`coe_neg`/`coe_sub` for the coercions from `ContinuousLinearMap` to `LinearMap` and primed versions `coe_zero'`/`coe_id'`/`coe_add'`/`coe_neg'`/`coe_sub'` for the coercions from `ContinuousLinearMap` to `Function`.

This PR adjusts the statements of `coe_mul` and `coe_pow` to fit this pattern, as well as adding `coe_one`.

Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants