Skip to content

[Merged by Bors] - feat(Data/Finsupp/Order): add lemma Finsupp.single_le_sum#35258

Closed
MichaelStollBayreuth wants to merge 2 commits intoleanprover-community:masterfrom
MichaelStollBayreuth:MS_Heights_API_Finsupp
Closed

[Merged by Bors] - feat(Data/Finsupp/Order): add lemma Finsupp.single_le_sum#35258
MichaelStollBayreuth wants to merge 2 commits intoleanprover-community:masterfrom
MichaelStollBayreuth:MS_Heights_API_Finsupp

Conversation

@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor

This adds an API lemma for Finsupp that turned out to be useful in Heights.


Open in Gitpod

@MichaelStollBayreuth MichaelStollBayreuth added the t-data Data (lists, quotients, numbers, etc) label Feb 13, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 13, 2026

PR summary 2598404fe9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ single_eval_le_sum
+ single_le_sum

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Ruben-VandeVelde
Copy link
Copy Markdown
Contributor

Ruben-VandeVelde commented Feb 14, 2026

Is there a multiplicative version for this?

@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor Author

I don't think Finsupp has a multiplicative version (at least, it is defined directly without using to_additive, and #check ℕ →₁ ℕ gives an error).

Comment thread Mathlib/Data/Finsupp/Order.lean Outdated
@faenuccio faenuccio added the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 16, 2026
Co-authored-by: Filippo A. E. Nuccio <filippo.nuccio@univ-st-etienne.fr>
@MichaelStollBayreuth MichaelStollBayreuth removed the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 16, 2026
@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor Author

@faenuccio Do you think this is ready to be merged now?

@faenuccio
Copy link
Copy Markdown
Contributor

faenuccio commented Feb 18, 2026

@faenuccio Do you think this is ready to be merged now?

Yes, thanks!

@faenuccio
Copy link
Copy Markdown
Contributor

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by faenuccio.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Feb 18, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Feb 23, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Feb 23, 2026
This adds an API lemma for `Finsupp` that turned out to be useful in [Heights](github.com/MichaelStollBayreuth/Heights).
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Feb 23, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(Data/Finsupp/Order): add lemma Finsupp.single_le_sum [Merged by Bors] - feat(Data/Finsupp/Order): add lemma Finsupp.single_le_sum Feb 23, 2026
@mathlib-bors mathlib-bors Bot closed this Feb 23, 2026
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Mar 2, 2026
…-community#35258)

This adds an API lemma for `Finsupp` that turned out to be useful in [Heights](github.com/MichaelStollBayreuth/Heights).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants