Skip to content

Conversation

@yuanyi-350
Copy link
Collaborator


Open in Gitpod

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Dec 29, 2025
@github-actions
Copy link

PR summary cc0ebd15d3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ rayleighQuotient_add

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.01)
Current number Change Type
144 -1 flexible linter exceptions

Current commit f09671efdb
Reference commit cc0ebd15d3

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions
Copy link

github-actions bot commented Dec 29, 2025

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@yuanyi-350 yuanyi-350 requested a review from grunweg December 29, 2025 13:22
@yuanyi-350 yuanyi-350 changed the title Chore(Analysis/rayleighQuotient): Clean up Mathlib\Analysis\InnerProductSpace\Rayleigh.lean chore(Analysis/rayleighQuotient): Clean up Mathlib\Analysis\InnerProductSpace\Rayleigh.lean Dec 29, 2025
@grunweg grunweg changed the title chore(Analysis/rayleighQuotient): Clean up Mathlib\Analysis\InnerProductSpace\Rayleigh.lean chore: clean up Mathlib\Analysis\InnerProductSpace\Rayleigh.lean Dec 29, 2025
@grunweg grunweg changed the title chore: clean up Mathlib\Analysis\InnerProductSpace\Rayleigh.lean chore(Analysis/InnerProductSpace/Rayleigh): clean up and fix a non-terminal simp Dec 29, 2025
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's have a second opinion; if I hear no dissent in 24 hours, I'll merge this.
maintainer merge?

@grunweg grunweg self-assigned this Dec 29, 2025
@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 29, 2025
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Dec 29, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 29, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 29, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Analysis/InnerProductSpace/Rayleigh): clean up and fix a non-terminal simp [Merged by Bors] - chore(Analysis/InnerProductSpace/Rayleigh): clean up and fix a non-terminal simp Dec 29, 2025
@mathlib-bors mathlib-bors bot closed this Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants