Skip to content

Conversation

@yuanyi-350
Copy link
Collaborator


Open in Gitpod

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Dec 29, 2025
@github-actions
Copy link

github-actions bot commented Dec 29, 2025

PR summary 725c803ee9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ iteratedDeriv_comp_const_sub
+ iteratedDeriv_comp_sub_const

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reuse the existing theorems:

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 30, 2025
yuanyi-350 and others added 2 commits December 31, 2025 08:14
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@yuanyi-350 yuanyi-350 removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 31, 2025
@yuanyi-350
Copy link
Collaborator Author

Do we need to mark these lemmas as @[simp] lemmas? I’m new to these conventions and don’t really understand the rules yet. I’ve heard that if a lemma can be proved using simp, then it doesn’t need to be tagged with @[simp]—is that true?

@j-loreaux
Copy link
Collaborator

@yuanyi-350 that's about proving lemmas by simp (without supplying any lemmas inside [...]). In this case, I'm not sure I would recommend marking these as simp lemmas, especially since the additive versions were not already marked that way. If we change our minds, this can be easily added later.

@j-loreaux
Copy link
Collaborator

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 31, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 31, 2025

This PR was included in a batch that timed out, it will be automatically retried

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 31, 2025

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@mathlib-bors mathlib-bors bot changed the title feat(Analysis/Deriv): Add iteratedDeriv_comp_sub_const [Merged by Bors] - feat(Analysis/Deriv): Add iteratedDeriv_comp_sub_const Dec 31, 2025
@mathlib-bors mathlib-bors bot closed this Dec 31, 2025
kim-em pushed a commit to kim-em/mathlib4 that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants