Skip to content

Conversation

@ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Dec 29, 2025

@ocfnash ocfnash requested a review from jcommelin December 29, 2025 11:41
@ocfnash ocfnash added awaiting-CI This PR doesn't pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) labels Dec 29, 2025
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Dec 29, 2025
@github-actions
Copy link

github-actions bot commented Dec 29, 2025

PR summary 92019987ed

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Submonoid.apply_ne_one_of_mem_or_inv_mem_closure
+ basisOfBase
+ exists_dual_baseOf_eq

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the awaiting-CI This PR doesn't pass CI yet. This label is automatically removed once it does. label Dec 29, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Dec 29, 2025
@mathlib4-dependent-issues-bot
Copy link
Collaborator

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 30, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@ocfnash ocfnash force-pushed the ocfnash/rs_base_ex_2 branch from c8dd8c3 to 1982e33 Compare December 30, 2025 20:01
@github-actions github-actions bot removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) large-import Automatically added label for PRs with a significant increase in transitive imports labels Dec 30, 2025
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 31, 2025

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@mathlib-bors mathlib-bors bot changed the title feat: all root system bases arise via IsAddIndecomposable.baseOf [Merged by Bors] - feat: all root system bases arise via IsAddIndecomposable.baseOf Dec 31, 2025
@mathlib-bors mathlib-bors bot closed this Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants