Skip to content

Conversation

@zcyemi
Copy link
Contributor

@zcyemi zcyemi commented Dec 29, 2025


Add oangle sign lemmas for two intersecting lines:
Sbtw.oangle_sign_eq_of_sbtw and Sbtw.oangle_sign_eq_of_sbtw_left

@github-actions
Copy link

github-actions bot commented Dec 29, 2025

PR summary 61d1f8fbef

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.Sbtw.oangle_sign_eq_of_sbtw
+ _root_.Sbtw.oangle_sign_eq_of_sbtw_left

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-euclidean-geometry Affine and axiomatic geometry label Dec 29, 2025
@github-actions
Copy link

github-actions bot commented Dec 29, 2025

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@zcyemi zcyemi changed the title feat(Geometry/Euclidean/Angle/Oriented/Affine) Add oangle sign lemmas for two intersecting lines feat(Geometry/Euclidean/Angle/Oriented/Affine): Add oangle sign lemmas for two intersecting lines Dec 29, 2025
Copy link
Collaborator

@JovanGerb JovanGerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, appart from the doc-strings

h.wbtw.oangle_sign_eq_of_ne_right _ h.ne_right

/-- Given two strict betweenness relations sharing a common point, and four corresponding
collinear points, the angles formed at the two outer points with the same pair of endpoints
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see four collinear points in the theorem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@jsm28
Copy link
Collaborator

jsm28 commented Dec 30, 2025

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by jsm28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-euclidean-geometry Affine and axiomatic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants