-
Notifications
You must be signed in to change notification settings - Fork 973
feat(Geometry/Euclidean/Angle/Oriented/Affine): Add oangle sign lemmas for two intersecting lines #33365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(Geometry/Euclidean/Angle/Oriented/Affine): Add oangle sign lemmas for two intersecting lines #33365
Conversation
PR summary 61d1f8fbefImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match our commit style conventions. |
JovanGerb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, appart from the doc-strings
| h.wbtw.oangle_sign_eq_of_ne_right _ h.ne_right | ||
|
|
||
| /-- Given two strict betweenness relations sharing a common point, and four corresponding | ||
| collinear points, the angles formed at the two outer points with the same pair of endpoints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see four collinear points in the theorem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by jsm28. |
Add oangle sign lemmas for two intersecting lines:
Sbtw.oangle_sign_eq_of_sbtwandSbtw.oangle_sign_eq_of_sbtw_left