-
Notifications
You must be signed in to change notification settings - Fork 973
feat(Mathlib/RingTheory/Ideal/Cotangent): dimension of cotangent spaces #33247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sun123zxy
wants to merge
6
commits into
leanprover-community:master
Choose a base branch
from
sun123zxy:cotangent-spanrank
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ This file contains some alternative statements of Nakayama's Lemma as found in | |
| * `Submodule.smul_le_of_le_smul_of_le_jacobson_bot` - Statement (4) in | ||
| [Stacks: Nakayama's Lemma](https://stacks.math.columbia.edu/tag/00DV). | ||
|
|
||
| * `Submodule.le_span_of_map_mkQ_le_map_mkQ_span_of_le_jacobson_bot` - Statement (8) in | ||
| * `Submodule.exists_set_equiv_eq_mkQ_span_of_span_eq_map_mkQ_of_le_jacobson_bot` - Statement (8) in | ||
| [Stacks: Nakayama's Lemma](https://stacks.math.columbia.edu/tag/00DV). | ||
|
|
||
| Note that a version of Statement (1) in | ||
|
|
@@ -184,10 +184,13 @@ lemma exists_sub_one_mem_and_smul_le_of_fg_of_le_sup {I : Ideal R} | |
| | add _ _ _ _ hx hy => exact N.add_mem hx hy | ||
| | zero => exact N.zero_mem | ||
|
|
||
| /-- **Nakayama's Lemma** - Statement (8) in | ||
| [Stacks 00DV](https://stacks.math.columbia.edu/tag/00DV). -/ | ||
| @[stacks 00DV "(8)"] | ||
| theorem le_span_of_map_mkQ_le_map_mkQ_span_of_le_jacobson_bot | ||
| /-- | ||
| If `N` is a finitely generated `R`-submodule of `M`, | ||
| `I` is an ideal contained in the Jacobson radical of `R`, | ||
| `t` is a set of `M` whose span image under the quotient map `M → M / (I • N)` | ||
| contains the image of `N`, then `N` is contained in the span of `t`. | ||
| -/ | ||
| lemma le_span_of_map_mkQ_le_map_mkQ_span_of_le_jacobson_bot | ||
| {I : Ideal R} {N : Submodule R M} {t : Set M} | ||
| (hN : N.FG) (hIjac : I ≤ jacobson ⊥) (htspan : map (I • N).mkQ N ≤ map (I • N).mkQ (span R t)) : | ||
| N ≤ span R t := by | ||
|
|
@@ -198,4 +201,96 @@ theorem le_span_of_map_mkQ_le_map_mkQ_span_of_le_jacobson_bot | |
| grw [sup_comm, ← htspan] | ||
| simp only [le_sup_right] | ||
|
|
||
| /-- | ||
| If `N` is a finitely generated `R`-submodule of `M`, | ||
| `I` is an ideal contained in the Jacobson radical of `R`, | ||
| `t` is a set of `M` whose span image under the quotient map `M → M / (I • N)` | ||
| is the image of `N`, then `t` spans `N`. | ||
| -/ | ||
| lemma span_eq_of_map_mkQ_span_eq_map_mkQ_of_le_jacobson_bot | ||
| {I : Ideal R} {N : Submodule R M} {t : Set M} | ||
| (hN : N.FG) (hIjac : I ≤ jacobson ⊥) (htspan : map (I • N).mkQ (span R t) = map (I • N).mkQ N) : | ||
| span R t = N := by | ||
| symm; apply le_antisymm | ||
| · apply le_span_of_map_mkQ_le_map_mkQ_span_of_le_jacobson_bot hN hIjac htspan.ge | ||
| · apply_fun comap (I • N).mkQ at htspan | ||
| simp only [comap_map_mkQ, smul_le_right, sup_of_le_right] at htspan | ||
| rw [← htspan]; apply le_sup_right | ||
|
|
||
| /- | ||
| If `N` is a finitely generated `R`-submodule of `M`, | ||
| `I` is an ideal contained in the Jacobson radical of `R`, | ||
| `s` is a set of `M / (I • N)` that spans the quotient image of `N`, | ||
| then any set `t` of `M` in bijection with `s` via the quotient map spans `N`. | ||
| -/ | ||
| theorem span_eq_of_set_equiv_eq_mkQ_span_of_span_eq_map_mkQ_of_le_jacobson_bot | ||
| {I : Ideal R} {N : Submodule R M} (s : Set (M ⧸ (I • N))) | ||
| (hN : N.FG) (hIjac : I ≤ jacobson ⊥) (hsspan : span R s = map (I • N).mkQ N) : | ||
| ∀ (t : Set M) (e : t ≃ s), (∀ x : t, e x = (I • N).mkQ x) → span R t = N := by | ||
| intro t e he | ||
| apply span_eq_of_map_mkQ_span_eq_map_mkQ_of_le_jacobson_bot hN hIjac | ||
| rw [← hsspan, map_span] | ||
| congr; ext y | ||
| constructor | ||
| · rintro ⟨x, hx, rfl⟩; rw [← he ⟨x, hx⟩]; simp | ||
| · intro hy; use (e.symm ⟨y, hy⟩).val | ||
| exact ⟨by simp, by rw [← he]; simp⟩ | ||
|
|
||
| /-- | ||
| **Nakayama's Lemma** - Statement (8) in | ||
| [Stacks 00DV](https://stacks.math.columbia.edu/tag/00DV). | ||
|
|
||
| If `N` is a finitely generated `R`-submodule of `M`, | ||
| `I` is an ideal contained in the Jacobson radical of `R`, | ||
| `s` is a set of `M / (I • N)` that spans the quotient image of `N`, | ||
| then there exists a spanning set `t` of `N` in bijection with `s` via the quotient map. | ||
| -/ | ||
| @[stacks 00DV "(8)"] | ||
| theorem exists_set_equiv_eq_mkQ_span_of_span_eq_map_mkQ_of_le_jacobson_bot | ||
| {I : Ideal R} {N : Submodule R M} (s : Set (M ⧸ (I • N))) | ||
| (hN : N.FG) (hIjac : I ≤ jacobson ⊥) (hsspan : span R s = map (I • N).mkQ N) : | ||
| ∃ (t : Set M) (e : t ≃ s), (∀ x : t, e x = (I • N).mkQ x) ∧ span R t = N := by | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems like a weird statement. Would it better to state
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes it is better! Resolved in the split PR. |
||
| let t := Quotient.out '' s | ||
| let e : t ≃ s := { | ||
| toFun := by intro ⟨x, hx⟩; use (I • N).mkQ x; rcases hx with ⟨y, hy, rfl⟩; simpa using hy | ||
| invFun := by intro ⟨y, hy⟩; use Quotient.out y; simpa [t] using hy | ||
| left_inv := by rintro ⟨x, y, hy, rfl⟩; simp | ||
| right_inv := by intro ⟨y, hy⟩; simp | ||
| } | ||
| use t, e | ||
| constructor | ||
| · intros; simp [e] | ||
| · apply span_eq_of_set_equiv_eq_mkQ_span_of_span_eq_map_mkQ_of_le_jacobson_bot | ||
| s hN hIjac hsspan t e (by intros; simp [e]) | ||
|
|
||
| /-- | ||
| The linear equivalence of the two definitions of `N / I • N`, | ||
| either as a quotient of `N` by its submodule `I • ⊤`, | ||
| or the image of `N` under the `R`-module quotient map `M → M / (I • N)`. | ||
| -/ | ||
| noncomputable def quotientIdealSubmoduleEquivMap (N : Submodule R M) (I : Ideal R) : | ||
| (N ⧸ (I • ⊤ : Submodule R N)) ≃ₗ[R] (map (I • N).mkQ N) := by | ||
| -- TODO: find a better place for this equivalence | ||
| refine LinearEquiv.ofBijective ?_ ⟨?_, ?_⟩ | ||
| · refine Submodule.liftQ _ ?_ ?_ | ||
| · exact { | ||
| toFun x := by | ||
| rcases x with ⟨x, hx⟩ | ||
| use ((I • N).mkQ x), x, hx | ||
| map_add' := by simp | ||
| map_smul' := by simp | ||
| } | ||
| · intro x hx | ||
| rw [mem_smul_top_iff] at hx | ||
| simp [hx] | ||
| · rw [← LinearMap.ker_eq_bot, LinearMap.ker_eq_bot'] | ||
| intro x hx | ||
| induction x using Submodule.Quotient.induction_on with | H x => | ||
| simp only [mkQ_apply, liftQ_apply, LinearMap.coe_mk, AddHom.coe_mk, mk_eq_zero, | ||
| Quotient.mk_eq_zero] at hx | ||
| simp only [Quotient.mk_eq_zero, mem_smul_top_iff, hx] | ||
| · rintro ⟨_, ⟨x, hx, rfl⟩⟩ | ||
| use Quotient.mk ⟨x, hx⟩ | ||
| simp | ||
|
|
||
| end Submodule | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really need this generality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it is better to prove
(M.restrictScalars R).spanRank = M.spanRankifM : Submodule S NandR -> Sis surjective.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and then you can recover this easily if you really want to)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes it is better. I was unaware of
restrictScalarspreviously. Changes are applied in the split PR.