Skip to content

Conversation

@kant2002
Copy link

No description provided.

@kant2002
Copy link
Author

@joneugster May I have your attention please?

@joneugster
Copy link
Collaborator

joneugster commented May 29, 2025

Thanks for the PR! I'll try to have a closer look next week. I'm a bit confused why you want to delete or rename the existing .sh files

Also if you extended the existing github actions (under .github) to run on Windows too and test your setup, it would be easier to ensure your code works and to merge

@kant2002
Copy link
Author

the only reason why I rename them, so when you run ./build on the terminal, in windows it will first look for .bat and for .cmd files. so that effectively make it friendly for docs on both platforms, without complicated ifs.

I will take a look at .github actions. That's for the hint.

@kant2002
Copy link
Author

@joneugster sorry for delay with Windows build, but can allow run this pipeline?

@abentkamp
Copy link
Collaborator

I have approved, but if this just for testing purposes, I think it would be easier if you ran the actions on your own fork. The build.yml file currently restricts actions to run only on dev and main branches. If you remove that restriction, the actions should start to run on the kant/add-windows-build branch of your fork as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants