replace AVCodec * with const AVCodec * to read codec information#115
Open
developer0hye wants to merge 1 commit intoleandromoreira:masterfrom
Open
replace AVCodec * with const AVCodec * to read codec information#115developer0hye wants to merge 1 commit intoleandromoreira:masterfrom
developer0hye wants to merge 1 commit intoleandromoreira:masterfrom
Conversation
Contributor
Author
|
Could you review this PR? The official example code also uses const*. https://github.com/FFmpeg/FFmpeg/blob/master/doc/examples/decode_video.c#L86 |
Owner
|
Thanks @developer0hye did you test using the current docker ffmpeg image to see if everything works fine? |
Contributor
Author
|
@leandromoreira Sorry, I didn't check it with current docker ffmpeg image. After checking it, I will tell you about it. |
Owner
Thank you :) |
I have the same commit please check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for writing the great tutorial!
I found some problem having been following your code.
The return type of
avcodec_find_decoderis changedAvcodec*toconst AVCodec*.https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/codec.h#L266