-
Notifications
You must be signed in to change notification settings - Fork 5
Feat: batched manhattan distance for a faster python implementation of the Laplacian kernel #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
can you please rebase onto new |
1459865 to
8a35a1c
Compare
|
@liam-o-marsh thanks! ruff is not supposed to check setup.py I think, at least in the CI workflow (also there are exclusion rules in the config) |
|
should close #120 |
|
@liam-o-marsh what do you think of this suggestion 3ba2079? (i can revert) |
|
btw why is RAM_BATCHING_SIZE so big? |
looks good to me, thanks!
I assumed this would mostly run on server hardware, but yeah for highly-multithreaded stuff this won't work |
|
slatm for qm7 is ~11k features, but we can use the C implementation... |
|
2b rebased onto new |
d922b19 to
a9af0a7
Compare
|
I think it's ready to be merged? |
|
maybe rebase on master first though |
a9af0a7 to
aea97e1
Compare
|
sounds good to me! |
Requirements: #115