Fix spahm a #116
Merged
Fix spahm a #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
to be merged after #115 |
This was referenced Nov 11, 2025
Closed
Merged
Closed
briling
force-pushed
the
fix-spahm-a
branch
3 times, most recently
from
590d262 to
f2b0ff4
Compare
- fix maxlen - add test for mr2021 - fix short versions for only_z
- fix SAD DM for open-shell - fix tests so they test SAD-diff
liam-o-marsh
approved these changes
Nov 18, 2025
YAY-C
reviewed
Dec 3, 2025
Contributor
YAY-C
left a comment
YAY-C
left a comment
There was a problem hiding this comment.
just a few comments that we can remove, I think.
and maybe the trimming of the vectors is unnecessary (in test), but needs to be checked.
tests/test_kernels.py
Outdated
Comment on lines
8
to
20
| #np.random.seed(666) | ||
| #X = np.random.rand(2,4) | ||
| #Y = np.random.rand(2,4) | ||
| #K_G_good = np.zeros((len(X),len(Y))) | ||
| #K_L_good = np.zeros((len(X),len(Y))) | ||
| #for i, x in enumerate(X): | ||
| # np.random.seed(666) | ||
| # X = np.random.rand(2,4) | ||
| # Y = np.random.rand(2,4) | ||
| # K_G_good = np.zeros((len(X),len(Y))) | ||
| # K_L_good = np.zeros((len(X),len(Y))) | ||
| # for i, x in enumerate(X): | ||
| # for j, y in enumerate(Y): | ||
| # K_G_good[i,j] = np.dot(x-y, x-y) | ||
| # K_L_good[i,j] = np.sum(abs(x-y)) | ||
| #np.exp(-K_G_good/2, out=K_G_good) | ||
| #np.exp(-K_L_good/2, out=K_L_good) | ||
| #K_dot_good = np.dot(X, Y.T) | ||
| #K_cos_good = K_dot_good / np.outer(np.linalg.norm(X, axis=1), np.linalg.norm(Y, axis=1)) | ||
| # np.exp(-K_G_good/2, out=K_G_good) | ||
| # np.exp(-K_L_good/2, out=K_L_good) | ||
| # K_dot_good = np.dot(X, Y.T) | ||
| # K_cos_good = K_dot_good / np.outer(np.linalg.norm(X, axis=1), np.linalg.norm(Y, axis=1)) |
Contributor
There was a problem hiding this comment.
@briling I'm not exactly sure why it's there, but I think we can remove this too!
Contributor
Author
There was a problem hiding this comment.
i wanted to keep it to show how the "true" data was generated
YAY-C
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix and refactor spahm(a)
maybe the slice generator and cursor class make it more complicated, so I can revert