Reject token binding status "present" in processCreate and processGet#131
Open
ScottHelme wants to merge 1 commit intolbuchs:masterfrom
Open
Reject token binding status "present" in processCreate and processGet#131ScottHelme wants to merge 1 commit intolbuchs:masterfrom
ScottHelme wants to merge 1 commit intolbuchs:masterfrom
Conversation
Per Level 2 spec (§7.1 Step 6, §7.2 Step 10), if tokenBinding.status is "present" the server must verify the binding ID against the TLS connection. Since the library does not implement Token Binding (which is deprecated and removed from Level 3), reject "present" rather than silently accepting an unverifiable claim. The "supported" status is still accepted — it simply means the browser supports Token Binding but did not use it for this connection. Fixes lbuchs#130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the W3C WebAuthn Level 2 spec (§7.1 Step 6 for registration, §7.2 Step 10 for authentication), if
clientDataJSON.tokenBinding.statusis"present", the server must verify thetokenBinding.idmatches the Token Binding ID of the TLS connection.The library does not implement Token Binding (which has been deprecated and removed from the Level 3 spec — no major browser supports it), so it cannot verify a binding ID. Currently
tokenBindingis completely ignored, meaningstatus: "present"is silently accepted as an unverifiable claim.This adds a check in both
processCreate()andprocessGet()that rejects"present":The
"supported"status is still accepted — it simply means the browser supports Token Binding but did not use it for this connection.Fixes #130