Reject non-empty attStmt in none attestation format#127
Open
ScottHelme wants to merge 1 commit intolbuchs:masterfrom
Open
Reject non-empty attStmt in none attestation format#127ScottHelme wants to merge 1 commit intolbuchs:masterfrom
ScottHelme wants to merge 1 commit intolbuchs:masterfrom
Conversation
Per W3C WebAuthn spec §8.7, when the attestation format is "none", attStmt must be an empty CBOR map. The library previously returned true unconditionally without checking the contents. Fixes lbuchs#126
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per W3C WebAuthn spec §8.7 (None Attestation Statement Format):
Currently
None::validateAttestation()returnstrueunconditionally without checkingattStmt. This means an attestation object withfmt: "none"but arbitrary data inattStmtis silently accepted.This adds a check that throws
WebAuthnException::INVALID_DATAifattStmtis not empty:Fixes #126