Added missing public key exception#116
Open
iljoja wants to merge 2 commits into
Open
Conversation
ScottHelme
pushed a commit
to report-uri/passkeys-php
that referenced
this pull request
May 13, 2026
The COSE_Key map for an OKP/EdDSA credential must include the public key x coordinate. The previous code silently assigned null, deferring the failure to a later use of the key. We now throw a clear exception at the parsing site. Adds a new WebAuthnException::MISSING_PUBLIC_KEY constant (17). Adopted from upstream PR lbuchs/WebAuthn#116 by @iljoja (originally surfaced by the ProtonMail fork).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was first noticed by ProtonMail fork.