Avoid deprecation error in PHP >= 8.5.#115
Open
antoineveldhoven wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated curl_close() call to ensure compatibility with PHP 8.5.0, where the function is deprecated. Since the library already requires PHP 8.0.0 minimum, where curl_close() has no effect, this call is unnecessary.
Changes:
- Removed the
curl_close($ch)call from thequeryFidoMetaDataServicemethod
Comments suppressed due to low confidence (1)
src/WebAuthn.php:531
- Corrected spelling of 'cetificates' to 'certificates'.
* @return int number of cetificates
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ScottHelme
pushed a commit
to report-uri/passkeys-php
that referenced
this pull request
May 13, 2026
curl_close() has been a no-op since PHP 8.0 (curl handles are now objects and are cleaned up automatically when out of scope) and is deprecated as of PHP 8.5. Since the library requires PHP >= 8.0, the call serves no purpose. Adopted from upstream PR lbuchs/WebAuthn#115 by @antoineveldhoven.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PHP 8.0.0, curl_close() has no effect and is deprecated as of PHP 8.5.0. Given that this library requires a minimum PHP version of 8.0.0, this call is no longer necessary.
This PR removes the call to curl_close to comply with PHP 8.5.0.