Skip to content

Add menuchart#7674

Closed
indevi wants to merge 6 commits into
layer5io:masterfrom
indevi:menucard
Closed

Add menuchart#7674
indevi wants to merge 6 commits into
layer5io:masterfrom
indevi:menucard

Conversation

@indevi

@indevi indevi commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes #7662

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shivam Tyagi <tyagishivam.dev@gmail.com>
@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2026-05-29 17:06 UTC

@Bhumikagarggg

Copy link
Copy Markdown
Contributor

@indevi Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

@indevi

indevi commented May 3, 2026

Copy link
Copy Markdown
Contributor Author

@Bhumikagarggg sure added

Comment thread src/collections/sistent/components/menu/guidance.mdx Outdated
Signed-off-by: Shivam Tyagi <tyagishivam.dev@gmail.com>

import { useState } from "react";
import { Menu, MenuItem, MenuList, Button, Box, Typography, Divider, ListItemIcon, ListItemText } from "@sistent/sistent";
import { MoreVert as MoreVertIcon, Edit as EditIcon, Delete as DeleteIcon, Share as ShareIcon, Download as DownloadIcon, FileCopy as FileCopyIcon, Print as PrintIcon } from "@mui/icons-material";

@rishiraj38 rishiraj38 May 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’ve these icons exported from sistent. Please use sistent to import them and if you didn't find any icon exported from sistent open a sub-issue here and add them.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indevi Any Updates??

Signed-off-by: Shivam Tyagi <tyagishivam.dev@gmail.com>
@Bhumikagarggg

Copy link
Copy Markdown
Contributor

@indevi Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

@indevi

indevi commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

@rishiraj38 @saurabhraghuvanshii requesting review please

@rishiraj38

Copy link
Copy Markdown
Member

@indevi, please make a commit so the preview can be built.

indevi added 2 commits May 11, 2026 22:01
Signed-off-by: Shivam Tyagi <tyagishivam.dev@gmail.com>
@indevi

indevi commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

@rishiraj38 hope this is the preview commit requested

@rishiraj38 rishiraj38 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check out this PR for fixing this detachment issue. (#7524)

Screen.Recording.2026-05-11.at.10.38.19.PM.mov

and Please center those menu buttons in overview and guidance

and also you have added too much content and it doesn't feel like they are in sequence please improve on that too

@rishiraj38

Copy link
Copy Markdown
Member

@indevi any updates ?

@indevi

indevi commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

Will push the fix this weekend

@rishiraj38

Copy link
Copy Markdown
Member

Will push the fix this weekend

???

@rishiraj38

Copy link
Copy Markdown
Member

@indevi any updates ?

@rishiraj38

Copy link
Copy Markdown
Member

stale PR

@rishiraj38 rishiraj38 closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sistent] Add Menu component to the sistent components page

4 participants