fix(seo): resolve crawlable links and aria-labels#933
Open
Daniel-1600 wants to merge 2 commits intolayer5io:masterfrom
Open
fix(seo): resolve crawlable links and aria-labels#933Daniel-1600 wants to merge 2 commits intolayer5io:masterfrom
Daniel-1600 wants to merge 2 commits intolayer5io:masterfrom
Conversation
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Daniel Mungai <chegedan699@gmail.com>
Daniel-1600
force-pushed
the
fix-seo-issues
branch
from
9bf8dae to
5ea4d48
Compare
Member
|
@Daniel-1600 I'm still not seeing any improvement |
- Add aria-label to all icon-only dropdown anchors (Academy, Videos, Meshery Docs, Kanvas, Catalog, SMP Spec, Nighthawk, Layer5 Academy) - Fix user-profile-url static href from '/' to 'https://cloud.layer5.io' - Add null guard for canvas.getContext() to prevent JS crash on pages without the visualizer element Lighthouse SEO audits link-text and crawlable-anchors now pass (0 items) Signed-off-by: Daniel Mungai <chegedan699@gmail.com>
Daniel-1600
force-pushed
the
fix-seo-issues
branch
from
2466e43 to
8aa8ac9
Compare
Author
|
hey @saurabhraghuvanshii after testing from the cli , im seeing no visible errors |
Member
|
@Daniel-1600 but we need seo score. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #918
Signed commits