Skip to content

fix(videos): remove hardcoded min suffix from durations#1064

Open
icoderarely wants to merge 2 commits into
layer5io:masterfrom
icoderarely:fix/hardcoded-min-suffix
Open

fix(videos): remove hardcoded min suffix from durations#1064
icoderarely wants to merge 2 commits into
layer5io:masterfrom
icoderarely:fix/hardcoded-min-suffix

Conversation

@icoderarely
Copy link
Copy Markdown
Contributor

Notes for Reviewers

This PR fixes #1052
image

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
@welcome
Copy link
Copy Markdown

welcome Bot commented May 21, 2026

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-1064/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the ' min' suffix from the video duration display in the video landing page partial. The review feedback suggests improving the HTML structure by replacing the

tags with tags to avoid unnecessary inline styles and removing redundant CSS classes for better maintainability.

Comment thread layouts/partials/video-landing-page.html Outdated
Comment thread layouts/partials/video-landing-page.html Outdated
…ased styling

Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix hardcoded min suffix for MM:SS video durations in UI

1 participant