Fix/video category navigation#1063
Open
Sbragul26 wants to merge 6 commits into
Open
Conversation
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Contributor
|
🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-1063/
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a hash-based navigation system for video categories, featuring CSS transitions and dynamic height adjustments for the video grid. The feedback identifies several areas for improvement: optimizing the Hugo template performance by using .Scratch instead of merge within loops, correcting the usage of safeHTMLAttr to ensure proper attribute escaping, and refining the JavaScript logic to preserve existing URL parameters and hashes when updating links.
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #1051 where opening a video category page directly always showed the "Getting Started" tab instead of the correct one. It also fixes the URL update and removes footer flicker when switching tabs. No breaking changes.
Signed commits