Add EMAIL_SEND_FROM configuration option#112
Open
filippo-orru wants to merge 2 commits intolawndoc:mainfrom
Open
Add EMAIL_SEND_FROM configuration option#112filippo-orru wants to merge 2 commits intolawndoc:mainfrom
filippo-orru wants to merge 2 commits intolawndoc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My email service provides an SMTP endpoint that requires a randomly generated username and password. The username is not a valid email address, so in the current implementation of stack-back, sending alerts fails:
The fix is simple: add a new configuration parameter to set the SMTP from address. If not provided, it falls back to
EMAIL_HOST_USERto maintain backwards compatibility.