fix: Bump MSRV to 1.82.0 #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: bump MSRV to 1.82.0
Summary
This PR updates the Minimum Supported Rust Version (MSRV) from various versions (1.74.1, 1.74.0, 1.81.0) to 1.82.0 across four LaunchDarkly Rust repositories as requested in SDK-1371.
Changes made:
rust-versionfields inCargo.tomlfiles to1.82.0rustup override setcommands in GitHub Actions workflows and tooling actions to use Rust 1.82rust-server-sdk-redisthat was exposed by the newer Rust version (manual_unwrap_or_default)Repositories updated:
Review & Testing Checklist for Human
match result { Ok(r) => r, _ => false }toresult.unwrap_or_default()inrust-server-sdk-redis/src/data_store.rs:249doesn't change behavior in the Redis store'sis_initializedmethodRecommended test plan:
Diagram
%%{ init : { "theme" : "default" }}%% graph TD subgraph "rust-server-sdk-redis" A1["Cargo.toml<br/>rust-version: 1.74.1 → 1.82.0"]:::major-edit A2[".github/actions/tooling/action.yml<br/>rustup override: 1.74.1 → 1.82.0"]:::major-edit A3["src/data_store.rs<br/>clippy fix: match → unwrap_or_default"]:::major-edit end subgraph "rust-server-sdk-evaluation" B1["Cargo.toml<br/>rust-version: 1.74.0 → 1.82.0"]:::major-edit B2[".github/actions/tooling/action.yml<br/>rustup override: 1.74.0 → 1.82.0"]:::major-edit end subgraph "rust-eventsource-client" C1["eventsource-client/Cargo.toml<br/>rust-version: 1.81.0 → 1.82.0"]:::major-edit C2[".github/workflows/ci.yml<br/>rustup override: 1.81 → 1.82"]:::major-edit end subgraph "rust-server-sdk" D1["launchdarkly-server-sdk/Cargo.toml<br/>rust-version: 1.81.0 → 1.82.0"]:::major-edit D2["contract-tests/Cargo.toml<br/>rust-version: 1.81.0 → 1.82.0"]:::major-edit D3[".github/workflows/ci.yml<br/>rustup override: 1.81 → 1.82 (2 locations)"]:::major-edit end subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
manual_unwrap_or_defaultlint in the Redis data storeLink to Devin run: https://app.devin.ai/sessions/61a6d2dcad704db2ae6197fcdbb2f68b
Requested by: @keelerm84