Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jul 8, 2025

chore: bump MSRV to 1.82.0

Summary

This PR updates the Minimum Supported Rust Version (MSRV) from various versions (1.74.1, 1.74.0, 1.81.0) to 1.82.0 across four LaunchDarkly Rust repositories as requested in SDK-1371.

Changes made:

  • Updated rust-version fields in Cargo.toml files to 1.82.0
  • Updated rustup override set commands in GitHub Actions workflows and tooling actions to use Rust 1.82
  • Fixed a clippy lint issue in rust-server-sdk-redis that was exposed by the newer Rust version (manual_unwrap_or_default)

Repositories updated:

  • rust-server-sdk-redis (1.74.1 → 1.82.0)
  • rust-server-sdk-evaluation (1.74.0 → 1.82.0)
  • rust-eventsource-client (1.81.0 → 1.82.0)
  • rust-server-sdk (1.81.0 → 1.82.0)

Review & Testing Checklist for Human

⚠️ Risk Level: YELLOW - 3 items requiring attention

  • Test the clippy fix behavior: Verify that the change from match result { Ok(r) => r, _ => false } to result.unwrap_or_default() in rust-server-sdk-redis/src/data_store.rs:249 doesn't change behavior in the Redis store's is_initialized method
  • Verify MSRV consistency: Double-check that all MSRV references were updated consistently across all repositories and no old version references remain
  • Test with Rust 1.82.0: Build and test the projects with the actual Rust 1.82.0 toolchain to ensure compatibility and that no new issues are introduced

Recommended test plan:

  1. Install Rust 1.82.0 and test building all four repositories
  2. Run the full test suites for each repository
  3. For rust-server-sdk-redis specifically, test Redis integration functionality to ensure the clippy fix doesn't break initialization checks

Diagram

%%{ init : { "theme" : "default" }}%%
graph TD
    subgraph "rust-server-sdk-redis"
        A1["Cargo.toml<br/>rust-version: 1.74.1 → 1.82.0"]:::major-edit
        A2[".github/actions/tooling/action.yml<br/>rustup override: 1.74.1 → 1.82.0"]:::major-edit
        A3["src/data_store.rs<br/>clippy fix: match → unwrap_or_default"]:::major-edit
    end
    
    subgraph "rust-server-sdk-evaluation"
        B1["Cargo.toml<br/>rust-version: 1.74.0 → 1.82.0"]:::major-edit
        B2[".github/actions/tooling/action.yml<br/>rustup override: 1.74.0 → 1.82.0"]:::major-edit
    end
    
    subgraph "rust-eventsource-client"
        C1["eventsource-client/Cargo.toml<br/>rust-version: 1.81.0 → 1.82.0"]:::major-edit
        C2[".github/workflows/ci.yml<br/>rustup override: 1.81 → 1.82"]:::major-edit
    end
    
    subgraph "rust-server-sdk"
        D1["launchdarkly-server-sdk/Cargo.toml<br/>rust-version: 1.81.0 → 1.82.0"]:::major-edit
        D2["contract-tests/Cargo.toml<br/>rust-version: 1.81.0 → 1.82.0"]:::major-edit
        D3[".github/workflows/ci.yml<br/>rustup override: 1.81 → 1.82 (2 locations)"]:::major-edit
    end
    
    subgraph Legend
        L1[Major Edit]:::major-edit
        L2[Minor Edit]:::minor-edit
        L3[Context/No Edit]:::context
    end
    
    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#87CEEB
    classDef context fill:#FFFFFF
Loading

Notes

  • Environment limitation: Local testing was not possible due to OpenSSL dependency issues in the development environment, so validation relied entirely on CI checks
  • Breaking change: This MSRV bump is a breaking change for users on older Rust versions
  • Clippy enforcement: The newer Rust version enforces stricter clippy rules, which required fixing the manual_unwrap_or_default lint in the Redis data store

Link to Devin run: https://app.devin.ai/sessions/61a6d2dcad704db2ae6197fcdbb2f68b
Requested by: @keelerm84

- Update rust-version in launchdarkly-server-sdk/Cargo.toml from 1.81.0 to 1.82.0
- Update rust-version in contract-tests/Cargo.toml from 1.81.0 to 1.82.0
- Update rustup override in CI workflow from 1.81 to 1.82 (both jobs)

Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner July 8, 2025 15:01
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration bot changed the title Bump MSRV to 1.82.0 chore: bump MSRV to 1.82.0 Jul 8, 2025
Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
@jsonbailey jsonbailey changed the title chore: bump MSRV to 1.82.0 fix: Bump MSRV to 1.82.0 Jul 8, 2025
@jsonbailey jsonbailey merged commit e55c176 into main Jul 8, 2025
4 checks passed
@jsonbailey jsonbailey deleted the devin/sdk-1371/bump-msrv branch July 8, 2025 15:56
keelerm84 pushed a commit that referenced this pull request Jul 8, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.6.0](2.5.1...2.6.0)
(2025-07-08)


### Features

* Inline context for custom and migration op events
([#120](#120))
([7a5da5c](7a5da5c))


### Bug Fixes

* Bump MSRV to 1.82.0
([#121](#121))
([e55c176](e55c176))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants