Conversation
| * | ||
| * @throws IllegalArgumentException if any required field is missing | ||
| */ | ||
| public void validate() { |
There was a problem hiding this comment.
Ah, we have to do this because JSON makes an empty one and then fills things in?
| return; | ||
| } | ||
| for (Event event : events) { | ||
| if (event == null || event.getEvent() == null) { |
There was a problem hiding this comment.
What is the process by which this could happen? And if it cannot happen, but does happen, then should it be silent?
|
|
||
| // if there's no payloads, return | ||
| List<PayloadIntent> payloads = serverIntentData.getPayloads(); | ||
| if (payloads == null || payloads.isEmpty()) { |
There was a problem hiding this comment.
It feels like this may also be something we would want to know if we are diagnosing an issue.
| } | ||
| putObject.validate(); | ||
| // if server intent hasn't been received yet, ignore the event | ||
| if (tempId == null) { |
There was a problem hiding this comment.
This was treated as an error in the Go implementation, and I also treated as an error. It feels to violate what should be a requirement of the protocol.
| } | ||
| payloadTransferred.validate(); | ||
| // if server intent hasn't been received yet, we should reset | ||
| if (tempId == null) { |
|
Declining this PR. We shifted to working on FDv2 in dotnet-core and the approach taken there is different than this PR has. In the interest of consistency between dotnet-core and java-core, it doesn't make sense to keep this code. |
2 participants
No description provided.