feat: Support stream init diagnostics events for FDv2.#133
Open
kinyoklion wants to merge 5 commits intomainfrom
Open
feat: Support stream init diagnostics events for FDv2.#133kinyoklion wants to merge 5 commits intomainfrom
kinyoklion wants to merge 5 commits intomainfrom
Conversation
kinyoklion
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/StreamingSynchronizerImpl.java
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/StreamingSynchronizerImpl.java
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/StreamingSynchronizerImpl.java
Show resolved
Hide resolved
Member
Author
|
bugbot review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches FDv2 streaming lifecycle/error handling and restart behavior, which could affect reconnection and initialization semantics; changes are guarded by extensive new unit tests and are largely additive (diagnostic recording).
Overview
Adds FDv2 streaming stream-init diagnostics by plumbing a
DiagnosticStoreintoStreamingSynchronizerImpl(viaDataSystemComponents) and recording init timestamp/duration with afailedflag.Updates streaming error/restart paths to distinguish deliberate restarts (e.g.
goodbye/caller-initiated) from failures, reset timing after the first successful changeset, and record failures on conversion/protocol/parsing errors and unexpected thread termination. Tests are expanded to validate diagnostics across success, HTTP/network errors, invalid data, and repeated restarts (including null-store safety).Written by Cursor Bugbot for commit ee478d9. This will update automatically on new commits. Configure here.