Skip to content

chore: Add thread priority for streaming synchronizer.#129

Merged
kinyoklion merged 1 commit intomainfrom
rlamb/streaming-thread-priority
Feb 4, 2026
Merged

chore: Add thread priority for streaming synchronizer.#129
kinyoklion merged 1 commit intomainfrom
rlamb/streaming-thread-priority

Conversation

@kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Feb 4, 2026

Note

Low Risk
Small, localized change that only affects the priority of a background streaming thread; main risk is invalid/out-of-range priorities causing runtime exceptions on some platforms.

Overview
Adds configurable thread priority to the FDv2 streaming synchronizer by passing DataSourceBuildInputs.getThreadPriority() into StreamingSynchronizerImpl and applying it via Thread#setPriority on the stream run thread.

Updates StreamingSynchronizerImpl’s constructor signature accordingly and adjusts all StreamingSynchronizerImplTest instantiations to supply a priority (using Thread.NORM_PRIORITY).

Written by Cursor Bugbot for commit 9678f1a. This will update automatically on new commits. Configure here.

@kinyoklion kinyoklion requested a review from a team as a code owner February 4, 2026 17:05
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@kinyoklion kinyoklion merged commit 92095e7 into main Feb 4, 2026
22 checks passed
@kinyoklion kinyoklion deleted the rlamb/streaming-thread-priority branch February 4, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants