Merged
Conversation
lib/shared/common/src/main/java/com/launchdarkly/sdk/collections/IterableAsyncQueue.java
Show resolved
Hide resolved
82a437f to
8c1b4bf
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
lib/shared/common/src/main/java/com/launchdarkly/sdk/collections/IterableAsyncQueue.java
Show resolved
Hide resolved
8c1b4bf to
dac4a9b
Compare
dac4a9b to
65e92d5
Compare
tanderson-ld
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: Add IterableAsyncQueue.
feat: Update minimum Java version to 1.8.
END_COMMIT_OVERRIDE
Note
Medium Risk
Raising
shared/common’s Java baseline to 1.8 can break consumers pinned to Java 7; the new queue is well-tested but adds new concurrency code paths.Overview
Adds
com.launchdarkly.sdk.collections.IterableAsyncQueue, a thread-safe unbounded FIFO queue whosetake()returns aCompletableFuturethat completes immediately when items exist or later whenput()supplies one, plus package docs.Updates
lib/shared/commonto target Java 8 (1.8) and adds an extensive JUnit test suite covering ordering, null handling, and multi-threaded producer/consumer behavior.Written by Cursor Bugbot for commit e78dcde. This will update automatically on new commits. Configure here.