fix: Call identify hooks during init.

[beekld]

Requirements

• I have added test coverage for new or changed functionality
• I have followed the repository's pull request submission guidelines
• I have validated my changes against all supported platform versions

Related issues

N/A

Describe the solution you've provided

Before this change, beforeIdentify and afterIdentify were only called when identify was called. After this change, they are also called as part of init.

Describe alternatives you've considered

None.

Additional context

I don't think this would be considered a breaking change, but I wouldn't mind a second opinion. The change in behavior is observable by the user, but the new behavior is what was originally intended. So I would consider this a bugfix, and would not expect customers to need to make any changes to their code to deal with the change.

---

Note

Medium Risk
Changes observable hook execution timing by invoking beforeIdentify/afterIdentify during LDClient init and by including plugin-provided hooks in that lifecycle, which could affect apps with side-effecting hooks. Scope is limited to hook plumbing and tests, with no auth or data model changes.

Overview
LDClient now executes identify hooks as part of initialization: it runs beforeIdentify with method name "init" and defers afterIdentify until the initial setOnline completes.

Plugin hooks are collected earlier (during LDClient init rather than LDClient.start) so plugin-provided hooks participate in the init identify lifecycle, and the hook helper APIs in LDClientIdentifyHook.swift are widened to internal to support this.

Tests are updated/expanded to assert the additional init-time hook calls, preserve hook ordering, and verify plugin hooks fire during init.

^{Written by Cursor Bugbot for commit ab0372a. This will update automatically on new commits. Configure here.}

[tanderson-ld]

The beforeIdentify hooks should run after the auto environment attributes are added to the context (so that the implementer of the beforeIdentify call can see all the added attributes), and before we use that modified context to load cache or make network connections.

https://github.com/launchdarkly/sdk-specs/tree/main/specs/HOOK-hooks#conditional-requirement-1412

So likely it needs to be called right after this block, but double check.

        if config.autoEnvAttributes {
            context = AutoEnvContextModifier(environmentReporter: environmentReporter, logger: config.logger).modifyContext(context)
        }

You can think of "identify" as updating the context the SDK is going to use and do things with. If the SDK does anything with the context that can be detected or observed by the outside world, such as making network requests or loading cache which impacts flag evals, and it does so before beforeIdentify, it has sorta violated the logical order and it is a externally detectable contradiction of the API.

[beekld]

Okay, I think I've got it, and I think that's the right place. I mean, it seems clear from the spec that beforeIdentify should be called before flagCache.getCachedData at least. It's not obvious on first glance whether the various make functions on the previous lines have side effects, so it's better to err on calling the hooks before them.

There was one slight complication -- Swift really does not like init methods calling member functions before all object properties have been initialized, and flagSynchronizer is initialized after the cache is loaded. But the code in executeBeforeIdentifyHooks is very short and doesn't access any properties other than hooks, so I copy-pasted the code into init.

Please take another look.

[tanderson-ld]

Did the commit get pushed?

[beekld]

🤦‍♀️ no. okay. it's been pushed now. sorry about that.

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}