Do not merge before v2 release feat: register plugin dynamically#278
Open
abelonogov-ld wants to merge 15 commits into
Open
Do not merge before v2 release feat: register plugin dynamically#278abelonogov-ld wants to merge 15 commits into
abelonogov-ld wants to merge 15 commits into
Conversation
…y/flutter-client-sdk into andrey/register-plugin * 'andrey/register-plugin' of ssh://github.com/launchdarkly/flutter-client-sdk: fix: Update launchdarkly_dart_common to version 1.8.1 (#277) chore(main): release launchdarkly_dart_common 1.8.1 (#273) feat: Update launchdarkly_event_source_client to version 2.1.0 (#276)
Add safeGetPluginHooks to handle a single plugin and return null on error, and reuse it within safeGetHooks. Export the new helper (and safeGetPluginName) from the package barrel file. Co-authored-by: Cursor <cursoragent@cursor.com>
* andrey/safe-get-plugin-hooks: refactor: extract safeGetPluginHooks helper in common_client
Co-authored-by: Cursor <cursoragent@cursor.com>
* andrey/safe-get-plugin-hooks: chore: apply dart format
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0ea85db. Configure here.
Co-authored-by: Cursor <cursoragent@cursor.com>
Roll back the CocoaPods integration and Flutter-migration changes that leaked in from running the example on iOS/macOS locally, and ignore the regenerated Podfile/Podfile.lock so they are not committed again. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds runtime plugin registration through
LDClient.registerPlugin. This API is not supposed to be used by Customers.plugin.register, so hooks are active during registration.plugin.hooksfails, while preserving existing safe handling for registration exceptions.Test Plan
plugin.registerruns.hooksgetters and throwingregistermethods.