Skip to content

Fix panic in JSONB decoder on invalid version byte #4158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrey8343 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −5
Open

Fix panic in JSONB decoder on invalid version byte #4158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7b2b72
Fix panic in JSONB decoder on invalid version byte
jrey8343 Feb 8, 2026
b7ab16b
Fix formatting
jrey8343 Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions sqlx-postgres/src/types/json.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,12 @@ where
let mut buf = value.as_bytes()?;

if value.format() == PgValueFormat::Binary && value.type_info == PgTypeInfo::JSONB {
assert_eq!(
buf[0], 1,
"unsupported JSONB format version {}; please open an issue",
buf[0]
);
// Check JSONB version byte - PostgreSQL currently only supports version 1
if buf[0] != 1 {
return Err(
format!("unsupported JSONB format version {} (expected 1)", buf[0]).into(),
Copy link
Collaborator

@abonander abonander Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
format!("unsupported JSONB format version {} (expected 1)", buf[0]).into(),
format!("unsupported JSONB format version {} (expected 1) or incorrect type/corrupt data", buf[0]).into(),

As long as we're touching this, might as well cover the other possible cases.

);
}

buf = &buf[1..];
}
Expand Down