Skip to content

Conversation

@iamjpotts
Copy link
Contributor

@iamjpotts iamjpotts commented Aug 22, 2025

Does your PR solve an issue?

The docstring for Query::try_bind is incorrect and misleading:

  • Incorrect - should reference the bind function just above it; references itself instead
  • Unclear - says error is returned for encoding the given bind argument value; actual behavior is to return an error if a prior bind argument value had failed encoding or the current bind argument failed encoding

Is this a breaking change?

No; documentation only

Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
@abonander abonander merged commit 0849fe3 into launchbadge:main Aug 22, 2025
104 checks passed
willothy pushed a commit to freestyle-sh/sqlx that referenced this pull request Dec 5, 2025
* chore(core): Fix docstring for Query::try_bind

Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>

* chore(core): Touch up docstring a little more

Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>

---------

Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants