fix: RawSql lifetime issues
#3613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
force-pushed
the
ab/fix-raw-sql
branch
2 times, most recently
from
0776c48 to
df14f86
Compare
Contributor
|
Hi @abonander! I wonder if we can get this merged and released recently. And I'm curious why it's marked as breaking, since I suppose it relaxes the lifetime bound which should be backward-compatible? |
Collaborator
Author
|
It adds a new type parameter to public methods, which would break UFCS calls. |
abonander
force-pushed
the
ab/fix-raw-sql
branch
from
df14f86 to
3a0f916
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3150
fixes #3581
fixes #3591
TODO:
Breaking Change
Strictly speaking, this is a breaking change because it adds the
DBtype parameter to all methods.