Fix log file resolution for stack logging driver #388
+312
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabist
force-pushed
the
fix/stack-logging-driver-resolution
branch
from
e4e595a to
be6dff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes log file resolution when using
stacklogging driver (e.g.,LOG_CHANNEL=stackwithLOG_STACK=daily)Key Changes
resolveChannelWithPath()method to traverse stack driver channels and find the actual log file pathContext
When
LOG_CHANNEL=stackandLOG_STACK=daily, theReadsLogstrait was falling back tostorage_path('logs/laravel.log')instead of resolving the daily log file (laravel-YYYY-MM-DD.log) from the underlying channel configuration.Testing
All 9
ReadLogEntriesTesttests pass, including existing tests for stack → daily resolution.