Add Korean translation and edit "AboutView.swift" file #10
Conversation
| } | ||
| .padding() | ||
| .frame(width: 325, height: 425) | ||
| .frame(width: 325, height: 475) |
There was a problem hiding this comment.
I modified the value of the height attribute to 475 in the AboutView.swift file.
There was a problem hiding this comment.
@lshbluesky
Good job.
My PR (before yours) also has About window slightly bigger and updated translations, please get Contributors lines and update your localization files.
There was a problem hiding this comment.
@laobamac
You see the interest we have in your app, 5 languages in a few days 🙂
| InfoRow(icon: "c", title: "copyright".localized, value: "© 2025 " + "rights_reserved".localized) | ||
| InfoRow(icon: "c.circle", title: "copyright".localized, value: "© 2025 " + "rights_reserved".localized) |
There was a problem hiding this comment.
I've also fixed the issue where the copyright icon doesn't show up in the About window. 🙂
It appears to be an error that occurred because the "c" symbol could not be found in the SF symbol.
Modifying it to "c.circle" will fix this issue and show the copyright icon as normal. :)
There was a problem hiding this comment.
@lshbluesky
Good catch. I noticed this but didn't think about this fix.
lshbluesky
changed the title
|
Hey, bro, I just saw the email reminder from Github. I will check these PRs in a few days and add some functions at the same time. I will link GithubAPI to realize that everyone can share their useful Patchsets in next version. Recently, I have a little gastrointestinal cold and still have a fever. I can't check these codes for the time being. Best regards! |
4 participants
Hello. 🙂
I would like to contribute to Korean translation.
If there is time, please review this Pull Request. 📋
Thank you for the good utility.
Have a good day. 🍀