chore: resolve oxlint warnings across web and SDK#34540
Merged
asukaminato0721 merged 2 commits intolanggenius:mainfrom Apr 21, 2026
Merged
chore: resolve oxlint warnings across web and SDK#34540asukaminato0721 merged 2 commits intolanggenius:mainfrom
asukaminato0721 merged 2 commits intolanggenius:mainfrom
Conversation
agenthaulk
requested review from
WTW0313,
Yeuoly,
crazywoola,
iamjoel,
laipz8200,
zhsama and
zxhlyh
as code owners
dosubot
Bot
added
the
size:M
…sed vars, and unnecessary escapes Fixes langgenius#25189 Changes: - Remove redundant `?? {}` / `|| {}` in spread operators (spread undefined is safe) - Remove unnecessary backslash escapes in single-quoted strings - Rename unused parameter `testCode` → `_testCode` - Convert ternary statement to if/else in embed.js - Replace regex with `.endsWith()` for simpler string matching - Add safe optional chaining in test file 16 files changed, 30 insertions, 28 deletions
agenthaulk
force-pushed
the
fix/issue-25189-oxlint-warnings
branch
from
62f8305 to
3402e7d
Compare
dosubot
Bot
added
size:XS
asukaminato0721
approved these changes
Apr 21, 2026
HanqingZ
pushed a commit
to HanqingZ/dify
that referenced
this pull request
Apr 23, 2026
Co-authored-by: Asuka Minato <i@asukaminato.eu.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25189
Resolves all
npx oxlintwarnings by addressing the following patterns across 16 files:...(foo ?? {})→...foo(spread ofundefinedis a no-op)\"inside single-quoted strings where"is validtestCode→_testCodeto satisfy no-unused-varsif/elseinembed.js.endsWith()suffices — simpler and more readable?? {}fallback where.at(-1)?.[2]could be undefined before destructuringVerification
npx oxlint— 0 warnings, 0 errors on all 16 filesFiles Changed
sdks/nodejs-client/(3 files),web/app/components/(7 files),web/context/(1 file),web/public/(1 file),web/scripts/(3 files),web/app/components/workflow/(1 file)