Skip to content

chore: enable erasableOnly in lint#31487

Merged
hyoban merged 6 commits intolanggenius:mainfrom
jubinsoni:27998-remove-enums-1
Mar 20, 2026
Merged

chore: enable erasableOnly in lint#31487
hyoban merged 6 commits intolanggenius:mainfrom
jubinsoni:27998-remove-enums-1

Conversation

@jubinsoni
Copy link
Copy Markdown
Contributor

@jubinsoni jubinsoni commented Jan 24, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

for : #27998

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@jubinsoni jubinsoni requested a review from iamjoel as a code owner January 24, 2026 09:22
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 24, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Jan 24, 2026
@dosubot dosubot Bot added the 💪 enhancement New feature or request label Jan 24, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @jubinsoni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's ESLint configuration to enforce a new coding standard. It specifically introduces a rule that prohibits the declaration of TypeScript enums, aiming to guide developers towards alternative patterns for defining constant sets and improve code consistency.

Highlights

  • ESLint Rule Addition: A new ESLint rule has been added to web/eslint.config.mjs to restrict the use of TypeScript enums.
  • Enum Restriction: The no-restricted-syntax rule now disallows TSEnumDeclaration with an error message "We should not use Enum".

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new ESLint rule to disallow the use of enum in the codebase. This is a good step towards standardizing on alternatives like union types, which can offer benefits in terms of bundle size and type safety. My review includes a suggestion to improve the error message for this new rule to make it more descriptive and helpful for developers, explaining the rationale and suggesting the preferred alternative.

Comment thread web/eslint.config.mjs Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@jubinsoni jubinsoni changed the title adding enum restrict rule feat: adding enum restrict rule Jan 24, 2026
Copy link
Copy Markdown
Member

@hyoban hyoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyoban hyoban added the status: awaiting response Issues waiting for a reply from the OP or another party label Jan 24, 2026
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 20, 2026
@hyoban hyoban changed the title feat: adding enum restrict rule chore: enable erasableOnly in lint Mar 20, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 20, 2026
@hyoban hyoban merged commit 3ce4372 into langgenius:main Mar 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. status: awaiting response Issues waiting for a reply from the OP or another party web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants