Don't warn if side-effecting main hook returns nil#452
Open
frenchy64 wants to merge 2 commits intolambdaisland:mainfrom
Open
Don't warn if side-effecting main hook returns nil#452frenchy64 wants to merge 2 commits intolambdaisland:mainfrom
main hook returns nil#452frenchy64 wants to merge 2 commits intolambdaisland:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
==========================================
- Coverage 74.62% 74.59% -0.04%
==========================================
Files 52 52
Lines 2822 2822
Branches 284 284
==========================================
- Hits 2106 2105 -1
Misses 521 521
- Partials 195 196 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I understand correctly, the
mainhook's return value is ignored.