fix: avoid spurious deleted line when diffing empty string#33
Closed
Yanhu007 wants to merge 1 commit intokylelemons:masterfrom
Closed
fix: avoid spurious deleted line when diffing empty string#33Yanhu007 wants to merge 1 commit intokylelemons:masterfrom
Yanhu007 wants to merge 1 commit intokylelemons:masterfrom
Conversation
strings.Split("", "\n") returns [""] (one empty string), not [].
This causes Diff("", content) to always show a removed blank line.
Add a splitLines helper that returns nil for empty input.
Fixes kylelemons#22
Author
|
Duplicate of #34, closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22
Problem
Diff("", "hello")produces:The spurious
-line appears becausestrings.Split("", "\n")returns[""](a slice containing one empty string), not[].Fix
Add a
splitLineshelper that returnsnilfor empty input, so the diff engine treats an empty string as having zero lines instead of one empty line.Testing
All existing tests pass. Manually verified: