Respect out1.gpar and out2.gpar parameters in ggdesplot #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
ggdesplot()to properly respect user-providedout1.gparandout2.gparparameters for customizing outline appearance. Previously, outline colors, line widths, and line types were hardcoded, completely ignoring these documented parameters.Changes
col,lwd, andltyfromout1.gparandout2.gparlistsgeom_tileborder()calls (lines 465-480 inR/ggdesplot.R)out1defaultlwd=3was being rendered aslwd=1.5)Testing
Tested with
agridat::besag.metdataset. All examples work as expected:Benefits
Users can now customize outline appearance as documented
Brings ggplot2 version closer to feature parity with lattice version
Fixes inconsistency between documented defaults and actual rendering
Enables matching the styling of lattice-based desplot examples