Use strip.cex parameter for strip text size in ggdesplot #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the strip text size was hardcoded to 5, ignoring the user-provided strip.cex parameter. Now the strip text size properly respects the strip.cex parameter by multiplying it by the base font size (11 points), consistent with ggplot2 conventions. This improvement ensures users can control the facet strip text size as documented.
Owner
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
strip.cexparameter inggdesplot()to properly control the facet strip text size. Previously, the strip text size was hardcoded to 5, ignoring the user-providedstrip.cexparameter.Changes
strip.text = element_text(size=5)tostrip.text = element_text(size = 11 * strip.cex)inR/ggdesplot.R(line 540)strip.cexparameter by multiplying it by the base font size (11 points), consistent with ggplot2 conventionsTesting
Tested with
agridat::besag.metdataset:strip.cex = 0.5produces smaller strip textstrip.cex = 1.5produces larger strip textstrip.cex = 0.75works as expectedBenefits