Skip to content

Fix zip file time#92

Open
kunitoki wants to merge 1 commit into
mainfrom
dev/fix_zip_file_timings
Open

Fix zip file time#92
kunitoki wants to merge 1 commit into
mainfrom
dev/fix_zip_file_timings

Conversation

@kunitoki
Copy link
Copy Markdown
Owner

This pull request makes a small but important fix to how file times are written in ZIP archives. Specifically, it corrects the encoding of the seconds field to match the ZIP file specification, which requires seconds to be stored in two-second increments.

  • Corrected the encoding of the seconds field in the ZipFile::Builder::Item::writeTimeAndDate method by shifting seconds right by one, ensuring compatibility with the ZIP file format.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.02%. Comparing base (5e9cddf) to head (047b96e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   73.01%   73.02%           
=======================================
  Files         547      547           
  Lines       53848    53848           
=======================================
+ Hits        39318    39323    +5     
+ Misses      14530    14525    -5     
Files with missing lines Coverage Δ
modules/yup_core/zip/yup_ZipFile.cpp 85.40% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9cddf...047b96e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant