[WIP] test: side-load the PR/CI-built NPD image into node e2e#1291
Conversation
The node e2e "NodeProblemDetector" test deploys a pod running NODE_PROBLEM_DETECTOR_IMAGE. To exercise the image built from this PR/CI run rather than one pulled from a registry, build a single-arch image archive, upload it next to the release tarball, and have the node e2e VM import it into containerd with `ctr images import` -- no registry involved. - Makefile: add build-image-archive (linux/amd64, docker-archive output). - build.sh: build and upload the archive for pr/ci; record its URL in the env file alongside the local image ref. - test/sideload-image.sh: instance startup-script that downloads the archive and imports it into the k8s.io containerd namespace once containerd is up. Requires a companion test-infra change to the ci-/pull-npd-e2e-node jobs (--instance-metadata=startup-script<test/sideload-image.sh,npd-image-url=... and --prepull-images=false). That change is backward compatible and can land first; until both are in, the e2e prepull still pulls from a registry. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
|
@dims: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
The node e2e "NodeProblemDetector" test deploys a pod running NODE_PROBLEM_DETECTOR_IMAGE. To exercise the image built from this PR/CI run rather than one pulled from a registry, build a single-arch image archive, upload it next to the release tarball, and have the node e2e VM import it into containerd with
ctr images import-- no registry involved.Requires a companion test-infra change to the ci-/pull-npd-e2e-node jobs (--instance-metadata=startup-script<test/sideload-image.sh,npd-image-url=... and --prepull-images=false). That change is backward compatible and can land first; until both are in, the e2e prepull still pulls from a registry.