Skip to content

azure: Move hardcoded task config to model using SDK types#18190

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
hakman:azure-https-kops-controller
Apr 14, 2026
Merged

azure: Move hardcoded task config to model using SDK types#18190
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
hakman:azure-https-kops-controller

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Apr 13, 2026

/cc @rifelpet

Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@k8s-ci-robot k8s-ci-robot requested a review from rifelpet April 13, 2026 21:05
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2026
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 13, 2026

/test pull-kops-e2e-azure-cni-cilium

@rifelpet
Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2026
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 14, 2026

/approve
/test all
/override pull-kops-e2e-azure-cni-cilium

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-azure-cni-cilium

Details

In response to this:

/approve
/test all
/override pull-kops-e2e-azure-cni-cilium

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2026
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 14, 2026

/test all
/override pull-kops-e2e-azure-cni-cilium

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-azure-cni-cilium

Details

In response to this:

/test all
/override pull-kops-e2e-azure-cni-cilium

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 14, 2026

/test pull-kops-e2e-azure-cni-cilium

1 similar comment
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 14, 2026

/test pull-kops-e2e-azure-cni-cilium

@k8s-triage-robot
Copy link
Copy Markdown

Retesting failed PR that otherwise appears ready for merge.

Please help us fix flaky tests by following our Flaky Tests Guide.

Prevent this bot from retesting with /lgtm cancel or /hold.
For this robot's configuration, see here.

/retest-required

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 14, 2026

/test pull-kops-e2e-azure-cni-cilium

@k8s-triage-robot
Copy link
Copy Markdown

Retesting failed PR that otherwise appears ready for merge.

Please help us fix flaky tests by following our Flaky Tests Guide.

Prevent this bot from retesting with /lgtm cancel or /hold.
For this robot's configuration, see here.

/retest-required

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 14, 2026

/test all
/test pull-kops-e2e-azure-cni-cilium

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 14, 2026

All green, except for the cleanup;

Ran 1208 of 7671 Specs in 1739.967 seconds
SUCCESS! -- 1208 Passed | 0 Failed | 0 Pending | 6463 Skipped

Ginkgo ran 1 suite in 29m13.577696461s
Test Suite Passed

/override pull-kops-e2e-azure-cni-cilium
/override pull-kops-e2e-k8s-aws-calico

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-azure-cni-cilium, pull-kops-e2e-k8s-aws-calico

Details

In response to this:

All green, except for the cleanup;

Ran 1208 of 7671 Specs in 1739.967 seconds
SUCCESS! -- 1208 Passed | 0 Failed | 0 Pending | 6463 Skipped

Ginkgo ran 1 suite in 29m13.577696461s
Test Suite Passed

/override pull-kops-e2e-azure-cni-cilium
/override pull-kops-e2e-k8s-aws-calico

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 7153796 into kubernetes:master Apr 14, 2026
27 checks passed
@hakman hakman deleted the azure-https-kops-controller branch April 14, 2026 15:39
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants