Skip to content

Conversation

@thockin
Copy link
Member

@thockin thockin commented Dec 13, 2025

Followup to #8694 - fix the tests.

Don't REQUIRE at least 1 character (which broke tests).

Retain trailing / on URLs if specified, but with simpler regex handling.

@ameukam @BenTheElder @cji

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2025
@k8s-ci-robot k8s-ci-robot added area/apps Application management, code in apps/ sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Dec 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thockin
Once this PR has been reviewed and has the lgtm label, please assign alvaroaleman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 13, 2025
Don't REQUIRE at least 1 character (which broke tests).

Retain trailing / on URLs if specified, but with simpler regex handling.
@BenTheElder
Copy link
Member

Don't REQUIRE at least 1 character (which broke tests).

I want to say requiring a character in this particular match was necessary but it's been a while, maybe we should be matching the no-characters case seperately? (and that case shouldn't allow query params etc?)

@thockin
Copy link
Member Author

thockin commented Dec 13, 2025

I didn't want to go refactoring all the config, so I opted to make it as similar in function as possible. I agree that it's a little weird to have the same location handling all of those cases...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps Application management, code in apps/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants